[PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops

Matthew Garrett mjg59 at srcf.ucam.org
Wed Jul 8 03:43:00 PDT 2009


On Wed, Jul 08, 2009 at 11:36:09AM +0100, Alan Jenkins wrote:
> 2009/7/8 Matthew Garrett <mjg59 at srcf.ucam.org>:
> > On Tue, Jun 30, 2009 at 11:31:18AM +0200, Corentin Chary wrote:
> >
> >> This patch is ok for me.
> >> All known Asus laptop do this in hardware.
> >
> > Even the ones which expose ACPI backlights and when
> > /sys/module/video/parameters/brightness_switch_enabled is false?
> 
> Wups, I don't know.  I have no reason to override that.

The problem in that case is that the kernel changes the backlight for 
us. The lack of consistency on this front makes life somewhat harder. 

In terms of the "Some hardware sends keyboard events but also changes 
the brightness", I'm working on a cleaner solution for this. The easiest 
would seem to be to generate a uevent when the backlight is changed, 
which would then allow userspace to pop up UI even though the key press 
events aren't propagated. It would seem to deal with the Eee (and older 
Thinkpad) cases quite nicely, but does require some more code in 
userspace.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org


More information about the hal mailing list