[PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops

[Corentin Chary]

On Tue, Jun 30, 2009 at 10:55 AM, Alan
Jenkins<alan-jenkins at tuffmail.co.uk> wrote:
> diff --git a/fdi/information/10freedesktop/10-laptop-panel-hardware.fdi b/fdi/information/10freedesktop/10-laptop-panel-hardware.fdi
> index ef35a18..25a4671 100644
> --- a/fdi/information/10freedesktop/10-laptop-panel-hardware.fdi
> +++ b/fdi/information/10freedesktop/10-laptop-panel-hardware.fdi
> @@ -4,16 +4,26 @@
>        notifications on keypresses, but will also change the brightness
>        directly in firmware. If software changes the value in response to
>        a press, there's a risk that a further event will be generated and
> -       a feedback loop occur. brightness_in_hardware indicates to clients
> -       that they should not act in response to keypress notifications. -->
> +       a feedback loop occur.
> +
> +       Even barring this worst case, the user experience will be degraded.
> +       Clients cannot always avoid incrementing/decrementing the brightness
> +       twice. They may try to detect whether the brightness has already been
> +       changed by firmware. However this will break down when multiple events
> +       occur before the client is able to process them.  This can obviously
> +       be a problem if the client is swapped out, or during system suspend.
> +       It has also been observed to occur through key repeat, showing
> +       an ugly flash (out-of-sequence brightness change) when switching
> +       between holding the "brightness down" and "brightness up" keys.
> +
> +       laptop_panel.brightness_in_hardware indicates to clients that they
> +       should not act in response to keypress notifications. -->
>   <device>
>     <match key="info.category" string="laptop_panel">
> -      <!-- For Asus EeePC -->
> +      <!-- For Asus EeePC and all known Asus laptops -->
>       <match key="/org/freedesktop/Hal/devices/computer:system.hardware.vendor"
>           string="ASUSTeK Computer INC.">
> -        <match key="/org/freedesktop/Hal/devices/computer:system.hardware.product" string="701">
> -          <merge key="laptop_panel.brightness_in_hardware" type="bool">true</merge>
> -        </match>
> +        <merge key="laptop_panel.brightness_in_hardware" type="bool">true</merge>
>       </match>
>       <match key="/org/freedesktop/Hal/devices/computer:system.hardware.vendor" string="TOSHIBA">
>         <match key="/org/freedesktop/Hal/devices/computer:system.hardware.product" string="SATELLITE M100">
>
>

This patch is ok for me.
All known Asus laptop do this in hardware.
Thanks


-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org