[PATCH] fix segfault in hal-storage-mount and don't lose fstype in probe-volume

Danny Kukawka danny.kukawka at web.de
Sun May 24 09:10:37 PDT 2009


On Sonntag, 24. Mai 2009, Simon Munton wrote:
> Attached patch checks that return value of libhal_volume_get_fstype() is
> not NULL before being passed to strcmp() in hal-storage-mount.c
>
> It also changes:
>
> if (libhal_changeset_set_property_string (cs, "volume.fstype", type))
>
> to
>
> if (!libhal_changeset_set_property_string (cs, "volume.fstype", type))
>
> in hald/linux/probing/probe-volume.c.
>
> This is how it was in 0.5.11, the change made in 0.5.12 causes
> libhal_changeset_set_property_string() to be called twice for
> "volume.fstype", the second time the the type is an empty string, which
> then makes hal lose the fstype.

Thanks, commited to git master and the 0.5.12(.1) branch.

Danny


More information about the hal mailing list