[PATCHES] kfreebsd support (Re: 0.5.14 release in two weeks?)

[Joe Marcus Clarke]

On Mon, 2009-11-23 at 04:40 +0100, Michael Biebl wrote:
> 2009/11/5 Martin Pitt <martin.pitt at ubuntu.com>:
> > Hello all,
> >
> > there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
> > release in about two weeks, to once again free everyone from carrying
> > heavy patches. So now would be a good time to send your remaining
> > patches to the list for review.
> 
> Hi Martin,
> 
> I've split up the patch that we currently have in Debian to add
> support for kfreebsd [1] and updated it to the current state in
> master.
> 
> PATCH 0001/ setproctitle is not defined on glibc (which is used in
> kfreebsd), so guard its usage with #ifdef
> PATCH 0002/ (e)glibc requires to link against -lrt. I used
> AC_SEARCH_LIBS, as this should handle the case nicely that -lrt's
> functionality is included in freebsd' libc
> PATCH 0003/ libufs is not (yet) part of kfreebsd, so make this
> functionality optional
> PATCH 0004/ for completeness sake I also included the patch which uses
> blkid instead of libvolume-id on kfreebsd.

I had problems with this patch when it was first committed.  FreeBSD
doesn't [yet] have a blkid port, and libvolume_id is working just fine
for us.  Could you #ifdef this patch so the libvolume_id code is still
present for FreeBSD?

> 
> 0004 is probably not suitable for upstream, whereas I think 0001-0003 is.
> I CCed Joe and Aurelien for their feedback / review.

Yeah, I agree.  I also have some patches in my local CVS repo which I
will try and merge this weekend.  They fix a lot of volume probing
issues.

Joe

> 
> Cheers,
> Michael
> 
> 
> 
> [1] http://patch-tracker.debian.org/patch/series/view/hal/0.5.13-4/50_kfreebsd.patch
-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/hal/attachments/20091123/5f145b4d/attachment.pgp