[HarfBuzz] HarfBuzz code in CVS

Lars Knoll lars at trolltech.com
Thu Apr 6 12:37:32 PDT 2006

On Thursday 06 April 2006 20:14, Behdad Esfahbod wrote:
> On Thu, 6 Apr 2006, it was written:
> > On Thu, 6 Apr 2006, Lars Knoll wrote:
> > > Done.
> >
> > Thanks.  I'll review them.  Most of the warnings as I remember
> > were simply signedness issues.
> Ok, I see you fixed the unused-parameter ones too.  Don't know if
> FT_UNUSED has any runtime penalty or not, but it's definitely
> cleaner and easier to setup than using the gcc attributes.  I
> just added some bits to harfbuzz-impl.h to define it if it's not
> defined, just in case it's not in older FreeType versions...

Good. I don't think it has runtime issues. At least gcc-4 should be able to 
optimise that code out. But that's easy to check :)

And I'll remove the dumper part from harfbuzz.c to reduce the size of the 
embedded code tomorrow.


More information about the HarfBuzz mailing list