[HarfBuzz] Unified Shaper

[Behdad Esfahbod]

On Fri, 2006-10-20 at 07:47 -0400, Lars Knoll wrote:
> 
> After a short chat with Behdad on IRC, I've gone ahead and done the
> move. 
> harfbuzz is now available from git:

Thanks Lars.

> git+ssh://git.freedesktop.org/git/harfbuzz
> git://anongit.freedesktop.org/git/harfbuzz

I finally got the time to check this out.

> I also created a "0.5" branch, that contains the code base currently
> used in 
> Pango and Qt.

I prefer to reorder the tree a bit.  First, the 0.5 need not be the
version with the shape.h removed.  You can branch off an earlier version
without that stuff.  Next, I really think we should put the shape.h
stuff in a separate branch (possibly a separate tree even, in people's
own trees), and let master branch be what Pango+Qt use plus bug fixes
plus tests, etc.  For example I want to fix what I think is a bug now:

Index: harfbuzz-open.c
===================================================================
RCS file: /cvs/gnome/pango/pango/opentype/harfbuzz-open.c,v
retrieving revision 1.2
diff -u -p -d -r1.2 harfbuzz-open.c
--- harfbuzz-open.c     25 Jul 2006 01:02:27 -0000      1.2
+++ harfbuzz-open.c     28 Dec 2006 00:56:01 -0000
@@ -1191,7 +1191,7 @@ static FT_Error  Get_Class1( HB_ClassDef
     *index = 0;
 
   if ( glyphID >= cdf1->StartGlyph &&
-       glyphID <= cdf1->StartGlyph + cdf1->GlyphCount )
+       glyphID < cdf1->StartGlyph + cdf1->GlyphCount )
   {
     *class = cva[glyphID - cdf1->StartGlyph];
     return FT_Err_Ok;

but I don't want to create the old mess with CVS, that is, to commit to
0.5, and to master.  Anyway, if you agree that the tree can use some
reordering, I can go ahead and create one and then replace the one on
the server.

Oh, we also should set up a hook to send commit messages to this list.
I find them very useful.  I just happened to find out that Simon has
been hacking on tests and stuff.   Cool things.  I wish I've got them in
the mail.


Anyway, I started have some other bits, writing in a separate mail.


> Cheers,
> Lars 
-- 
behdad
http://behdad.org/

"Those who would give up Essential Liberty to purchase a little
 Temporary Safety, deserve neither Liberty nor Safety."
        -- Benjamin Franklin, 1759