[HarfBuzz] Yet another patch

Behdad Esfahbod behdad at behdad.org
Fri Aug 31 15:46:42 PDT 2007


Hi Simon :),

This one fixing issue that first ligature in a line was having wrong
mark attachments.  I was debugging a bigger problem with mark
attachments, that's ongoing.

http://bugzilla.gnome.org/show_bug.cgi?id=302952 (fixed)

http://bugzilla.gnome.org/show_bug.cgi?id=437633 (not fixed yet)


2007-08-29  Behdad Esfahbod  <behdad at gnome.org>

        Bug 302952 – The placement of a diacritic marks for an arabic ligature
        is not correct

        * pango/opentype/harfbuzz-buffer.c (hb_buffer_allocate_ligid): Don't
        use zero as allocated ligature id.  Zero means no ligature id.


Index: harfbuzz-buffer.c
===================================================================
--- harfbuzz-buffer.c   (revision 2415)
+++ harfbuzz-buffer.c   (working copy)
@@ -223,5 +223,5 @@ hb_buffer_copy_output_glyph ( HB_Buffer 
 FT_UShort
 hb_buffer_allocate_ligid( HB_Buffer buffer )
 {
-  return buffer->max_ligID++;
+  return ++buffer->max_ligID;
 }


-- 
behdad
http://behdad.org/

"Those who would give up Essential Liberty to purchase a little
 Temporary Safety, deserve neither Liberty nor Safety."
        -- Benjamin Franklin, 1759






More information about the HarfBuzz mailing list