[HarfBuzz] Potential bug

Behdad Esfahbod behdad at behdad.org
Fri Sep 26 05:50:11 PDT 2008


Peter Hunter wrote:
> In HarfBuzz-GPOS.c:: Position_CursiveChain
> Is this curious sequence
> 
>    HB_UInt   i, j;
>    HB_Position positions = buffer->positions;
> 
>    /* First handle all left-to-right connections */
>    for (j = 0; j < buffer->in_length; j--)
>    {...}
> 
> As j is an unsigned int, this loop can only ever be executed once, surely the j-- should be j++ ?

Thanks for pointing out.  Yes, I fixed this in Pango a few weeks ago.  Forgot
to commit in HarfBuzz.  Will do today.

behdad

> Peter Hunter



More information about the HarfBuzz mailing list