[HarfBuzz] patch for hb-ot-layout.cc to prevent null-deref

Behdad Esfahbod behdad at behdad.org
Mon Aug 16 11:37:38 PDT 2010


Thanks Jonathan.  Committed.  I still need to rewrite the face to be a cache
of arbitrary tables, but have committed the fix for now.  Looking into the
'head' one now.



behdad

On 08/16/10 09:55, Jonathan Kew wrote:
> It looks to me like the _get_gdef, _get_gsub, and _get_gpos functions in hb-ot-layout.cc need an additional null-check, for the case where the face is actually the dummy _hb_face_nil object; this has no ot_layout, and therefore these functions risk deref'ing a null pointer.
> 
> I ran into this in the course of investigating a 'head' table issue (see following mail).
> 
> Suggested patch is attached.
> 
> JK
> 
> 
> 
> 
> 
> 



More information about the HarfBuzz mailing list