[HarfBuzz] harfbuzz.old issue with fallback hebrew shaping

Behdad Esfahbod behdad at behdad.org
Fri Dec 17 17:35:45 PST 2010


Hi Lars and Simon,

The following patch was suggested to me.  It looks correct.  Can you please
review?

diff --git a/src/harfbuzz-hebrew.c b/src/harfbuzz-hebrew.c
index 67029be..4f75660 100644
--- a/src/harfbuzz-hebrew.c
+++ b/src/harfbuzz-hebrew.c
@@ -84,7 +84,7 @@ HB_Bool HB_HebrewShape(HB_ShaperItem *shaper_item)
         logClusters[0] = 0;

         for (i = 1; i < shaper_item->item.length; ++i) {
-            hb_uint16 base = shapedChars[slen-1];
+            hb_uint16 base = shapedChars[cluster_start];
             hb_uint16 shaped = 0;
             HB_Bool invalid = FALSE;
             if (uc[i] == Dagesh) {


Thanks,
behdad



More information about the HarfBuzz mailing list