[HarfBuzz] harfbuzz-ng: Branch 'master' - 7 commits

Jonathan Kew jonathan at jfkew.plus.com
Mon May 24 11:34:52 PDT 2010


On 24 May 2010, at 19:28, Jonathan Kew wrote:

> Hi Behdad (or Martin),
> 
> It looks like things are currently (80af2812fb3b231ddcb4608ec13c6038a681c818) a little broken with regard to #includes....
> 
> First, hb-shape.cc fails to compile because hb_ot_shape() has not been declared; it needs to #include "hb-ot-shape.h".
> 
> And second, hb-ot.h is a public C-language header and as such, it should not include hb-ot-shape-private.hh, which is a private C++-language file. Changing hb-ot.h to include hb-ot-shape.h instead seems to resolve this.

And third, hb-ot-shape.cc needs to #include "hb-ot-shape.h", so that the hb_ot_shape() function gets defined with the proper linkage.

So altogether, the fixes I did to get my build to work are in the attached patch.

JK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hb-include-fixes.patch
Type: application/octet-stream
Size: 1759 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20100524/04128f2a/attachment.obj>


More information about the HarfBuzz mailing list