[HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

Behdad Esfahbod behdad at behdad.org
Tue Nov 2 16:37:24 PDT 2010


Pushed this one out.  By the way, you can push to the main repo now.

behdad

On 11/02/10 18:58, Behdad Esfahbod wrote:
> Thanks Jonathan.  Not intended.  I try to avoid that but gcc doesn't have a
> switch to warn when I miss :(.  Will push with my next batch.
> 
> b
> 
> On 11/02/10 18:19, Jonathan Kew wrote:
>> Hi Behdad,
>>
>> Please remove the trailing comma from the joining-types enumeration in hb-ot-shape-complex-arabic.cc, as trailing commas in enums can cause a compile error if gcc is feeling strict about things.....
>>
>> Thanks,
>>
>> JK
>>
>> ------------------------------------------------------------------------------------------------------------
>> diff --git a/gfx/harfbuzz/src/hb-ot-shape-complex-arabic.cc b/gfx/harfbuzz/src/hb-ot-shape-complex-arabic.cc
>> --- a/gfx/harfbuzz/src/hb-ot-shape-complex-arabic.cc
>> +++ b/gfx/harfbuzz/src/hb-ot-shape-complex-arabic.cc
>> @@ -38,17 +38,17 @@ enum {
>>    JOINING_TYPE_C               = JOINING_TYPE_D,
>>    JOINING_GROUP_ALAPH          = 3,
>>    JOINING_GROUP_DALATH_RISH    = 4,
>>    NUM_STATE_MACHINE_COLS       = 5,
>>  
>>    /* We deliberately don't have a JOINING_TYPE_L since that's unused in Unicode. */
>>  
>>    JOINING_TYPE_T = 6,
>> -  JOINING_TYPE_X = 7, /* means: use general-category to choose between U or T. */
>> +  JOINING_TYPE_X = 7  /* means: use general-category to choose between U or T. */
>>  };
>>  
>>  /*
>>   * Joining types:
>>   */
>>  
>>  
>>  /*
>> ------------------------------------------------------------------------------------------------------------
>>
>> _______________________________________________
>> HarfBuzz mailing list
>> HarfBuzz at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/harfbuzz
>>



More information about the HarfBuzz mailing list