[HarfBuzz] a bug in configure in Pango harfbuzz-ng-external branch

suzuki toshiya mpsuzuki at hiroshima-u.ac.jp
Sun Nov 28 20:12:25 PST 2010


Hi Behdad,

I'm not sure if this should be posted to gtk+-i18n list or here.
If harfbuzz list is inappropriate list to discuss, please let
me know.

The configure.in of Pango harfbuzz-ng-external branch has a line
like:

*)         IFS="$pango_save_ifs" AC_MSG_ERROR([specified module $module not recognized]) ;;

I'm afraid that multiple command separated by space in single
line is danger in shell script (in my case, configure script
gets the error here during the running). So, I prefer this line
should be divided to 2 lines aslike:

diff --git a/configure.in b/configure.in
index 87fe0e9..b3a7e0b 100644
--- a/configure.in
+++ b/configure.in
@@ -569,7 +569,8 @@ for module in $included_modules; do
     *-win32)   INCLUDED_WIN32_MODULES="$INCLUDED_WIN32_MODULES $included_path" ;;
     *-atsui)   INCLUDED_ATSUI_MODULES="$INCLUDED_ATSUI_MODULES $included_path" ;;
     *-lang)    INCLUDED_LANG_MODULES="$INCLUDED_LANG_MODULES $included_path" ;;
-    *)         IFS="$pango_save_ifs" AC_MSG_ERROR([specified module $module not recognized]) ;;
+    *)         IFS="$pango_save_ifs"
+               AC_MSG_ERROR([specified module $module not recognized]) ;;
   esac
 done
 IFS="$pango_save_ifs"

Is this wrong fix?

Regards,
mpsuzuki

P.S.
There is no way to file a bug specific to harfbuzz-ng-external branch
in current bugzilla in gnome.org. I'm sorry for posting a silly patch
in this list.



More information about the HarfBuzz mailing list