[HarfBuzz] harfbuzz-ng: Branch 'master'

[Wouter Bolsterlee]

Hi Behdad,

Thanks for working on this. I've added a few comments below.

    — Wouter

Behdad Esfahbod schreef op di 22-02-2011 om 15:06 [-0800]:
> commit 5353bf439c150492708ef9337078cfd73b83627b
[snip]
> +int
> +main (int argc, char **argv)
> +{
[...]
> +  cairo_face = cairo_ft_font_face_create_for_ft_face (ft_face, 0);
> +
> +  draw ();
> +  draw ();

What is the reason to invoke draw() twice?

> +  cairo_surface_write_to_png (surface, out_file);

Error handling here would be helpful to diagnose issues that fall
outside the scope of HarfBuzz, e.g. file system permissions. Something
like this would do I think:

  cairo_status_t status;
  st = cairo_surface_write_to_png (surface, out_file);
  if (status != CAIRO_STATUS_SUCCESS) {
    fprintf (stderr, "Failed to write output file: `%s'\n", cairo_status_to_string (status));
    exit (1);
  }

> +  return 0;
> }

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20110226/4d8e2ad8/attachment.pgp>