[HarfBuzz] harfbuzz.old issue with fallback hebrew shaping

[Behdad Esfahbod]

Hi Lars,

On 01/14/11 10:08, lars.knoll at nokia.com wrote:
> The patch below looks incomplete to me, because it would also need a
> change in line 146 in this case:
> 
>             if (shaped) {
>                 if (shaper_item->font->klass->canRender(shaper_item->font,
> (HB_UChar16 *)&shaped, 1)) {
>                     shapedChars[slen-1] = shaped; // <<<<<<<<<<<
>                 } else
>                     shaped = 0;
>             }
> 
> It should say cluster_start here as well. But even then I think the patch
> is wrong as I only try to combine two adjacent chars (base + diacritic).
> If there are two diacritics and they are ordered differently I'm don't
> think sure we should reorder and combine them.
> 
> Does the person who proposed the patch any test cases this would fix?

You're right.  Same person sent me the additional chunk later, but then also
said that it doesn't fix all Hebrew positioning problems.  Let me put you in
contact so you can work it out.

behdad