[HarfBuzz] [PATCH] Adding a configure flag to disable building of tests
behdad at behdad.org
Wed Jul 20 13:44:04 PDT 2011
On 07/20/11 05:40, Tom Hacohen wrote:
> Dear all,
> Currently, the testing code depends on g_test_fail which was only introduced
> in glib 2.30. This means that the harfbuzz build now depends on glib 2.30 was
> is not necessary for regular harfbuzz.
I actually fixed that last week, but seems like I had not pushed it out. Done
I'd rather keep the configure magic to a minimum for now until I decide
exactly what kind of configure API I want to provide.
> One solution, would be checking the existence of this function or checking
> that the glib version is new enough, and only then build the testing code. I
> opted for the more specific solution - letting people disable building the tests.
> Many people don't care about the tests anyway, so allowing to disable them is
> probably a good idea anyway.
> Currently, just to keep behaviour, I made test building on by default (tbh, I
> think it should be off by default) and people can disable them using
> Attached is a patch to implement the described behaviour.
> HarfBuzz mailing list
> HarfBuzz at lists.freedesktop.org
More information about the HarfBuzz