[HarfBuzz] [PATCH] Implement threading primitives on Windows; fix compile error and leak

Behdad Esfahbod behdad at behdad.org
Wed May 11 18:35:15 PDT 2011


n 05/11/11 15:58, Bradley Grainger wrote:
> It does seem like this would need a destructor, too, to avoid leaking CRITICAL_SECTION objects (unless they're only ever destroyed at process shutdown, when it wouldn't be necessary).

That was the idea.  But I added it anyway.  Not that we explicitly support
unloading the DLL...


> Of course, then the struct would need to be made non-copyable to avoid inadvertent early destruction.

Good point.  Thanks.  Pushed.

behdad



More information about the HarfBuzz mailing list