[HarfBuzz] Compile error (using harfbuzz-20120730.tar.bz2 on osx)

[Rolf Langenhuijzen]

Worked perfectly, thanks.

It seems I have to explicitly set the --shapers=ot option to get --features to work. Correct? Locally it says coretext,ot,old,fallback as available shapers.
When I check my online version on an Ubuntu config it only shows ot,fallback (no coretext for example). It's also v0.9.0, but I think older than this latest.

I'm not sure about what 'coretext' does or is as shaper, but it seems to work when I set it to "ot" which makes sense when I want to test ot features.

Rolf


On Jul 30, 2012, at 11:49 PM, Behdad Esfahbod wrote:

> Fixed. And I uploaded a new tarball (under the same name).
> 
> On 07/30/2012 05:36 PM, Rolf Langenhuijzen wrote:
>> You are fast, indeed it helped! But then it goes wrong on some other part:
>> 
>> ---------------
>> ...
>> GEN    libharfbuzz.la
>> Undefined symbols for architecture x86_64:
>>  "__hb_coretext_shaper_face_data_destroy", referenced from:
>>      _hb_face_destroy in libharfbuzz_la-hb-font.o
>>      hb_shape_plan_plan(hb_shape_plan_t*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>      hb_shape_plan_create_cached(hb_face_t*, hb_segment_properties_t const*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>  "__hb_coretext_shaper_font_data_destroy", referenced from:
>>      _hb_font_destroy in libharfbuzz_la-hb-font.o
>>      hb_shape_plan_execute(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, hb_feature_t const*, unsigned int)in libharfbuzz_la-hb-shape-plan.o
>>  "__hb_coretext_shape", referenced from:
>>      hb_shape_plan_plan(hb_shape_plan_t*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>      hb_shape_plan_execute(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, hb_feature_t const*, unsigned int)in libharfbuzz_la-hb-shape-plan.o
>>      hb_shape_plan_create_cached(hb_face_t*, hb_segment_properties_t const*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>      all_shapers       in libharfbuzz_la-hb-shaper.o
>>  "__hb_coretext_shaper_face_data_create", referenced from:
>>      hb_shape_plan_plan(hb_shape_plan_t*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>      hb_shape_plan_create_cached(hb_face_t*, hb_segment_properties_t const*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>  "__hb_coretext_shaper_shape_plan_data_create", referenced from:
>>      hb_shape_plan_plan(hb_shape_plan_t*, hb_feature_t const*, unsigned int, char const* const*)in libharfbuzz_la-hb-shape-plan.o
>>  "__hb_coretext_shaper_font_data_create", referenced from:
>>      hb_shape_plan_execute(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, hb_feature_t const*, unsigned int)in libharfbuzz_la-hb-shape-plan.o
>>  "__hb_coretext_shaper_shape_plan_data_destroy", referenced from:
>>      hb_shape_plan_destroy(hb_shape_plan_t*)      in libharfbuzz_la-hb-shape-plan.o
>> ld: symbol(s) not found for architecture x86_64
>> collect2: ld returned 1 exit status
>> make[4]: *** [libharfbuzz.la] Error 1
>> make[3]: *** [all-recursive] Error 1
>> make[2]: *** [all] Error 2
>> make[1]: *** [all-recursive] Error 1
>> make: *** [all] Error 2
>> ---------------
>> 
>> Rolf
>> 
>> On Jul 30, 2012, at 10:45 PM, Jonathan Kew wrote:
>> 
>>> On 30/7/12 21:25, Rolf Langenhuijzen wrote:
>>>> I tried installing the latest version.
>>>> ./configure runs without problems.
>>>> when I do "make" it stops:
>>>> -----------
>>>> …
>>>> CXX    libharfbuzz_la-hb-ot-layout.lo
>>>> In file included from hb-ot-layout.cc:34:
>>>> hb-ot-layout-gsub-table.hh: In member function ‘bool Ligature::apply(hb_apply_context_t*) const’:
>>>> hb-ot-layout-gsub-table.hh:588: error: no matching function for call to ‘MAX(unsigned int, int)’
>>>> hb-ot-layout-gsub-table.hh:607: error: no matching function for call to ‘MAX(unsigned int, int)’
>>>> make[4]: *** [libharfbuzz_la-hb-ot-layout.lo] Error 1
>>>> make[3]: *** [all-recursive] Error 1
>>>> make[2]: *** [all] Error 2
>>>> make[1]: *** [all-recursive] Error 1
>>>> make: *** [all] Error 2
>>>> (quits)
>>>> -----------
>>> 
>>> The attached patch should fix this.
>>> 
>>> JK
>>> 
>>> 
>>> <patch1.txt>_______________________________________________
>>> HarfBuzz mailing list
>>> HarfBuzz at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/harfbuzz
>> 
>> _______________________________________________
>> HarfBuzz mailing list
>> HarfBuzz at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/harfbuzz
>>