[HarfBuzz] harfbuzz: Branch 'master' - 3 commits

Behdad Esfahbod behdad at kemper.freedesktop.org
Sun Oct 28 20:29:29 PDT 2012


 src/hb-buffer.cc |    2 +-
 src/hb-icu-le.cc |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 4c1d9244617e472464722e64d2cdbc1f9e8827f6
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Sun Oct 28 20:27:25 2012 -0700

    Minor

diff --git a/src/hb-icu-le.cc b/src/hb-icu-le.cc
index 8fc22a1..d73752d 100644
--- a/src/hb-icu-le.cc
+++ b/src/hb-icu-le.cc
@@ -189,7 +189,7 @@ retry:
     info[j].codepoint = glyphs[i];
     info[j].cluster = clusters[indices[i]];
 
-    /* icu-le doesn't seem to have separapte advance values. */
+    /* icu-le doesn't seem to have separate advance values. */
     info[j].mask = positions[2 * i + 2] - positions[2 * i];
     info[j].var1.u32 = 0;
     info[j].var2.u32 = -positions[2 * i + 1];
commit 38b015e57ffa75d3b078a368c23685beb7c3f946
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Sun Oct 28 20:11:47 2012 -0700

    Fix hb_buffer_set_length(buffer, 0)
    
    Was causing invalid realloc()s.

diff --git a/src/hb-buffer.cc b/src/hb-buffer.cc
index 2f8f511..b65beff 100644
--- a/src/hb-buffer.cc
+++ b/src/hb-buffer.cc
@@ -71,7 +71,7 @@ hb_buffer_t::enlarge (unsigned int size)
   if (unlikely (_hb_unsigned_int_mul_overflows (size, sizeof (info[0]))))
     goto done;
 
-  while (size > new_allocated)
+  while (size >= new_allocated)
     new_allocated += (new_allocated >> 1) + 32;
 
   ASSERT_STATIC (sizeof (info[0]) == sizeof (pos[0]));
commit b7115b63be72e109b51f538ba581aed1017b2d55
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Sun Oct 28 20:11:42 2012 -0700

    Add XXX

diff --git a/src/hb-icu-le.cc b/src/hb-icu-le.cc
index 41143fe..8fc22a1 100644
--- a/src/hb-icu-le.cc
+++ b/src/hb-icu-le.cc
@@ -138,6 +138,7 @@ retry:
   ALLOCATE_ARRAY (LEUnicode, chars, buffer->len);
   ALLOCATE_ARRAY (unsigned int, clusters, buffer->len);
 
+  /* XXX Use UTF-16 decoder! */
   for (unsigned int i = 0; i < buffer->len; i++) {
     chars[i] = buffer->info[i].codepoint;
     clusters[i] = buffer->info[i].cluster;



More information about the HarfBuzz mailing list