[HarfBuzz] harfbuzz-ng: Branch 'master'

Behdad Esfahbod behdad at behdad.org
Thu Sep 6 12:17:46 PDT 2012


On 09/06/2012 02:47 PM, Harshula wrote:
>> >    ALLOCATE_ARRAY (const HB_UChar16, item.string, chars_len);
>> > +  ALLOCATE_ARRAY (unsigned short, item.log_clusters, chars_len + 2);
> Why is the length "chars_len + 2"?

1. I *think* old harfbuzz also adds a final entry to that array,
2. It's widely reported (from Chromium people for example) that some of the
old HarfBuzz backends (Tibetan IIRC) make an off-by-one access past that array.

In short: to be on the safe side.

behdad



More information about the HarfBuzz mailing list