[HarfBuzz] Pointer initialization from false

Kenichi Ishibashi bashi at chromium.org
Mon Sep 10 06:51:22 PDT 2012


Hi Behdad,

The current revision can't compile with clang++ if -Werror option is
specified.

src/hb-open-type-private.hh:437:93: error: initialization of pointer of
type 'OT::GenericArrayOf<OT::IntType<unsigned short>,
OT::OffsetTo<OT::LigatureSet> > *' to null from a constant boolean
expression [-Werror,-Wbool-conversion]
    if (unlikely (!this->allocate_size<Type> (((char *) &obj) + size -
this->head))) return false

I'd appreciate if you could use NULL instead of false here.

Thanks,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20120910/f2e063cf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: return-null-instead-of-false.diff
Type: application/octet-stream
Size: 628 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20120910/f2e063cf/attachment.obj>


More information about the HarfBuzz mailing list