[HarfBuzz] build fails due to setmode() in options.cc

Jonathan Kew jfkthame at googlemail.com
Mon Feb 11 14:21:56 PST 2013


On 11/2/13 22:02, Behdad Esfahbod wrote:
> Ok, we need to limit that to Windows platforms then.  And we need a check
> instead of the below:
>
>    defined(_MSC_VER) || defined(__MINGW32__)
>
> that also handles Cygwin.
>
> behdad

I believe

   #if defined(_WIN32) || defined(__CYGWIN__)

should cover things for all of MSVC, mingw and cygwin, at least.


>
> On 02/11/2013 06:56 AM, Jonathan Kew wrote:
>> The current code in util/options.cc fails to build for me on OS X because of
>> the two uses of setmode(<file>, _O_BINARY). It seems that I have a setmode
>> function, so HAVE_SETMODE is true, but it's not actually the same thing as you
>> were expecting on Win32.
>>
>





More information about the HarfBuzz mailing list