[HarfBuzz] icu-le-hb

[Dejan Kovacevic]

 > I'm not talking about style here.  It just pollutes the diff output.

Oh, I see. Sorry.


> Not really.  It replaces ICU LayoutEngine, so doesn't make sense to be part of
> it.  Though, now I'm going to propose that the wrapper be imported into ICU
> itself as a compile-time option.

This is precisely what I'm talking about. Read my words "part of it" as a "compile-time option".

Dejan


> -----Original Message----- 
> From: "Behdad Esfahbod" <behdad at behdad.org> 
> To: "Dejan Kovacevic" <dejan at d-type.com>, harfbuzz at lists.freedesktop.org 
> Cc: behdad at kemper.freedesktop.org, "Steven R. Loomis" <srl at icu-project.org> 
> Date: 11/15/13 13:26 
> Subject: Re: [HarfBuzz] icu-le-hb 
> 
> On 13-11-15 01:15 PM, Dejan Kovacevic wrote:
> >  > Any reason you've made so much whitespace and cosmetic changes?  Makes
> >> reviewing your work much harder than it has to be.
> > 
> > Heh, I though the same before I started reviewing the original code... :)
> 
> I'm not talking about style here.  It just pollutes the diff output.
> 
> 
> > Anyway, I made these formatting changes to be more consistent with ICU Layout Engine's code. Once I realized that the wrapper code is really just the LayoutEngine.cpp, my idea was that this wrapper should perhaps be a part of ICU LE.
> 
> Not really.  It replaces ICU LayoutEngine, so doesn't make sense to be part of
> it.  Though, now I'm going to propose that the wrapper be imported into ICU
> itself as a compile-time option.
> 
> Thanks anyway,
> behdad
> 
> >> -----Original Message----- 
> >> From: "Behdad Esfahbod" <behdad at behdad.org> 
> >> To: "Dejan Kovacevic" <dejan at d-type.com>, harfbuzz at lists.freedesktop.org 
> >> Cc: behdad at kemper.freedesktop.org, "Steven R. Loomis" <srl at icu-project.org> 
> >> Date: 11/15/13 12:58 
> >> Subject: Re: [HarfBuzz] icu-le-hb 
> >>
> >> Any reason you've made so much whitespace and cosmetic changes?  Makes
> >> reviewing your work much harder than it has to be.
> >>
> >> On 13-11-15 12:33 AM, Dejan Kovacevic wrote:
> >>>  Attached is the modified/simplified icu-le-hb wrapper (a wrapper to use HarfBuzz as a direct replacement for the ICU Layout Engine). It consists of only two files: LayoutEngine-HB.cpp and LayoutEngine-HB.h. These two files should be copied to ICU's source/layout/ folder. Then the wrapper can be built by compiling the following files:
> >>>
> >>> gcc -c -I <path_to_harfbuzz_include_folder> source/layout/LayoutEngine-HB.cpp
> >>> gcc -c source/layout/LEFontInstance.cpp
> >>> gcc -c source/layout/LEGlyphStorage.cpp
> >>> gcc -c source/layout/LEInsertionList.cpp
> >>>
> >>> and linked with the HarfBuzz lib.
> >>>
> >>> This was tested with the most recent version of ICU (ICU 52) and HarfBuzz 0.9.23.
> >>>
> >>> Comments and questions are welcome.
> >>>
> >>>> -----Original Message----- 
> >>>> From: "Behdad Esfahbod" <behdad at behdad.org> 
> >>>> To: "Dejan Kovacevic" <dejan at d-type.com>, harfbuzz at lists.freedesktop.org 
> >>>> Cc: behdad at kemper.freedesktop.org 
> >>>> Date: 11/13/13 17:01 
> >>>> Subject: Re: [HarfBuzz] icu-le-hb 
> >>>>
> >>>> On 13-11-13 04:52 PM, Dejan Kovacevic wrote:
> >>>>>  OK, will do this tonight.
> >>>>
> >>>> Thanks.  Really curious to see them!
> >>>>
> >>>>
> >>>>> Dejan
> >>>>>
> >>>>>> -----Original Message----- 
> >>>>>> From: "Behdad Esfahbod" <behdad at behdad.org> 
> >>>>>> To: "Dejan Kovacevic" <dejan at d-type.com>, harfbuzz at lists.freedesktop.org 
> >>>>>> Cc: behdad at kemper.freedesktop.org 
> >>>>>> Date: 11/13/13 16:47 
> >>>>>> Subject: Re: [HarfBuzz] icu-le-hb 
> >>>>>>
> >>>>>> On 13-11-13 04:32 PM, Dejan Kovacevic wrote:
> >>>>>>>
> >>>>>>> A few days ago I downloaded and tried icu-le-hb (a wrapper to use HarfBuzz as a direct replacement for the ICU Layout Engine). I got it to work but only after making some changes and fixes. After that I created a simpler wrapper, one that consists of only one .cpp and .h file and which can be simply placed in ICU's source/layout/ folder and built as an alternative ICU Layout Engine.
> >>>>>>>
> >>>>>>> Is  there any interest in this wrapper? If so, to whom can I direct my patches? I also have a couple of questions/comments.
> >>>>>>
> >>>>>> Yes, definitely.  Please send them both to me.
> >>>>>>
> >>>>>>> Thanks,
> >>>>>>> Dejan
> >>>>>>
> >>>>>> -- 
> >>>>>> behdad
> >>>>>> http://behdad.org/
> >>>>>
> >>>>>
> >>>>> _______________________________________________
> >>>>> HarfBuzz mailing list
> >>>>> HarfBuzz at lists.freedesktop.org
> >>>>> http://lists.freedesktop.org/mailman/listinfo/harfbuzz
> >>>>>
> >>>>
> >>>> -- 
> >>>> behdad
> >>>> http://behdad.org/
> >>>
> >>
> >> -- 
> >> behdad
> >> http://behdad.org/
> > 
> > 
> > 
> 
> -- 
> behdad
> http://behdad.org/