[HarfBuzz] harfbuzz: Branch 'master' - 5 commits

[Behdad Esfahbod]

On 13-09-03 06:08 PM, Khaled Hosny wrote:
> On Tue, Sep 03, 2013 at 04:21:12PM -0400, Behdad Esfahbod wrote:
>> Are you shaping at upem size?
> 
> That is just the output of hb-shape, so I guess yes.
> 
>> If Uniscribe returns the old value then this is definitely a bug.
> 
> Seems so:
> 
>   $ cat test | hb-shape.exe amiri-regular.ttf --shapers=uniscribe
>   [uni06DD=0+2620|one.small=1 at -2210,0+0|two.small=2 at -1610,0+0|three.small=3 at -1010,0+0]
> 
>   $ cat test | hb-shape.exe amiri-regular.ttf --shapers=ot
>   [uni06DD=0+2620|one.small=1 at -2209,0+1|two.small=2 at -1609,0+1|three.small=3 at -1009,0+1]
> 
>> Feel free to suggest a patch.  Or we can just revert.
> 
> I’m not sure I understand the math behind that commit, so I can’t
> suggest a fix.

It's simply adding .5, supposedly to get round instead of floor behavior.  I
probably screwed up.  Will check.


>> BTW, is Amiri still on SF, or github?  If it's on github, may be a good idea
>> to set it up on travis-ci.org, then add a hook from harfbuzz github to trigger
>> amiri tests on travis, and send failure reports to harfbuzz list.
> 
> There is a github mirror, that would be nice if it can be done, but I
> need to check how to setup travis.

It's trivial.  Check harfbuzz/.travis.yml.  You need to enable a hook in the
github repo too.

I'll go check how to hook up harfbuzz commits to trigger amiri tests.


-- 
behdad
http://behdad.org/