[HarfBuzz] problem with hb_ot_layout_lookup_would_substitute

Luis de Bethencourt luis at debethencourt.com
Tue Jan 7 07:18:14 PST 2014


On 7 January 2014 10:08, Behdad Esfahbod <behdad at behdad.org> wrote:

> On 14-01-07 10:59 PM, Luis de Bethencourt wrote:
> >
> > I understand, which is why I think we should share this task. I'm happy
> to
> > write docs, if someone proof checks them.
>
> Right, and thanks for that.  Since I already gave you an assignment with
> hb-set (in private), how about you document that API first?
>
>
Makes sense.


> When I was writing unit tests for most of the API, I found that it lights
> up
> the corner cases of the API I never thought about before.  What if
> something's
> NULL, or 0, or in error, etc.  The unit tests (in hb/tests/api/) have not
> been
> updated since the marathon I did about 1.5 years ago.  So, how about when
> you
> (and others) document an API, make sure there are unit tests for that too?
>
>
Hadn't thought about that. Noted.


> Ok, lets get down to pull requests now!
>
> Cheers,
> --
> behdad
> http://behdad.org/
>

Yes! PRs is what it is all about :)
If everybody in the list showed a little bit of love to the docs, they
would be great in no time. Let's do it.

Luis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20140107/b09385a6/attachment.html>


More information about the HarfBuzz mailing list