[HarfBuzz] harfbuzz: Branch 'master'

Behdad Esfahbod behdad at kemper.freedesktop.org
Wed Jul 9 14:07:56 PDT 2014


 test/shaping/run-tests.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6bd5646f1b865a76304a67e03a6161afcfef293f
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Wed Jul 9 17:07:06 2014 -0400

    [tests] Remove bash'ish
    
    Apparently on travis-ci, bash is linked to dash, which doesn't
    understand "let".  Failing tests were not being noticed.  See eg:
    
      https://travis-ci.org/behdad/harfbuzz/jobs/29544211
    
    Don't rely on bash.

diff --git a/test/shaping/run-tests.sh b/test/shaping/run-tests.sh
index 4f34f94..a2cdf32 100755
--- a/test/shaping/run-tests.sh
+++ b/test/shaping/run-tests.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 test "x$srcdir" = x && srcdir=.
 test "x$builddir" = x && builddir=.
@@ -21,7 +21,7 @@ for f in "$@"; do
 		if ! test "x$glyphs" = "x$glyphs_expected"; then
 			echo "Actual:   $glyphs" >&2
 			echo "Expected: $glyphs_expected" >&2
-			let fails=$fails+1
+			fails=$((fails+1))
 		fi
 	done < "$f"
 done


More information about the HarfBuzz mailing list