[HarfBuzz] A plea to make HarfBuzz easier to build.

[Behdad Esfahbod]

On 15-12-16 12:06 AM, Jamie Dale wrote:
> The way I handled this was to create a define called HAVE_STUB_GETENV (which
> is a really weird name in hindsight) in my config.h file. I then just set that
> define, along with HAVE_INTEL_ATOMIC_PRIMITIVES, when building for PS4.
> 
> I'm not sure if you'd want to take that into HarfBuzz proper, or whether you'd
> want a better way?

If there's a macro to detect PS4, we can add that.  We already do that for WinCE:

#  if defined(_WIN32_WCE)
     /* Some things not defined on Windows CE. */
#    define strdup _strdup
#    define getenv(Name) NULL
#    if _WIN32_WCE < 0x800
#      define setlocale(Category, Locale) "C"
static int errno = 0; /* Use something better? */
#    endif
...

behdad


> #ifdef HAVE_STUB_GETENV
> // Stub out getenv as not all platforms support it
> #define getenv(name) 0
> #endif // HAVE_STUB_GETENV
> 
> -Jamie.
> <https://www.avast.com/lp-safe-emailing?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
> 	This email has been sent from a virus-free computer protected by Avast.
> www.avast.com
> <https://www.avast.com/lp-safe-emailing?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
> 
> 
> <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> 
> On 15 December 2015 at 11:40, Behdad Esfahbod <behdad.esfahbod at gmail.com
> <mailto:behdad.esfahbod at gmail.com>> wrote:
> 
>     On 15-12-13 09:33 PM, Jamie Dale wrote:
>     > You'll need a define to stub out getenv for a PS4 build
> 
>     I'll take a patch to hb-private.hh to do that.
> 
>