[HarfBuzz] harfbuzz: Branch 'master'

Jonathan Kew jfkthame at gmail.com
Thu Aug 10 08:38:18 UTC 2017


On 10/08/2017 05:43, Martin Hosken wrote:
> Dear Behdad,
> 
>> -  if (buffer == NULL)
>> +  if (!buffer)
> 
> Always wanting to learn. How does this cause a divide by zero? Or what led you to make the change?

It doesn't, that's purely stylistic. The real change in this commit 
comes later on:

      const OT::IndexSubtableRecord *subtable_record = 
this->cblc->find_table(glyph, &x_ppem, &y_ppem);
-    if (subtable_record == NULL)
+    if (!subtable_record || !x_ppem || !y_ppem)
        return false;

with the addition of the zero-check for the x_ppem and y_ppem values.



More information about the HarfBuzz mailing list