[HarfBuzz] harfbuzz: Branch 'master' - 2 commits

Behdad Esfahbod behdad at kemper.freedesktop.org
Thu Jul 5 09:35:24 UTC 2018


 src/hb-ot-layout-gsubgpos-private.hh |    2 +-
 src/hb-private.hh                    |   12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 1ebaa090d80bf0b59308d2c70f5e58dd8da47450
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Thu Jul 5 14:04:13 2018 +0430

    Disable vectorization
    
    Disable vectorization for now.  To correctly use them, we should
    use posix_memalign() to allocate them.  Otherwise, can cause
    misaligned access.
    
    https://bugs.chromium.org/p/chromium/issues/detail?id=860184

diff --git a/src/hb-private.hh b/src/hb-private.hh
index 41e6c200..5cec8e0b 100644
--- a/src/hb-private.hh
+++ b/src/hb-private.hh
@@ -1107,6 +1107,18 @@ struct HbOpXor
 
 /* Compiler-assisted vectorization. */
 
+/*
+ * Disable vectorization for now.  To correctly use them, we should
+ * use posix_memalign() to allocate them.  Otherwise, can cause
+ * misaligned access.
+ *
+ * https://bugs.chromium.org/p/chromium/issues/detail?id=860184
+ */
+#if !defined(HB_VECTOR_SIZE)
+#  define HB_VECTOR_SIZE 0
+#endif
+
+
 /* The `vector_size' attribute was introduced in gcc 3.1. */
 #if !defined(HB_VECTOR_SIZE)
 #  if defined( __GNUC__ ) && ( __GNUC__ >= 4 )
commit 18a06f8a662ca7a9e63f74c6443e24a035c40655
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Thu Jul 5 14:03:48 2018 +0430

    Fix warning
    
    ../../src/hb-ot-layout-gsubgpos-private.hh:391:18: warning: missed loop optimization, the loop counter may overflow [-Wunsafe-loop-optimizations]

diff --git a/src/hb-ot-layout-gsubgpos-private.hh b/src/hb-ot-layout-gsubgpos-private.hh
index 661085d5..cbaa6488 100644
--- a/src/hb-ot-layout-gsubgpos-private.hh
+++ b/src/hb-ot-layout-gsubgpos-private.hh
@@ -388,7 +388,7 @@ struct hb_ot_apply_context_t :
     inline bool prev (void)
     {
       assert (num_items > 0);
-      while (idx >= num_items)
+      while (idx > num_items - 1)
       {
 	idx--;
 	const hb_glyph_info_t &info = c->buffer->out_info[idx];


More information about the HarfBuzz mailing list