[HarfBuzz] harfbuzz: Branch 'master'

Behdad Esfahbod behdad at kemper.freedesktop.org
Sun Sep 30 10:23:35 UTC 2018


 util/options.hh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5285b34798cb7ee672343d00cbe066ea8a2ef83
Author: Behdad Esfahbod <behdad at behdad.org>
Date:   Sun Sep 30 12:23:01 2018 +0200

    [util] Remove unneeded virtual
    
    clang warning:
    
    ../../util/options.hh:72:13: warning: destination for this 'memset' call is a pointer to dynamic class
          'option_parser_t'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
        memset (this, 0, sizeof (*this));
        ~~~~~~  ^
    ../../util/options.hh:72:13: note: explicitly cast the pointer to silence this warning
        memset (this, 0, sizeof (*this));
                ^
                (void*)

diff --git a/util/options.hh b/util/options.hh
index 4d920ad0..40e1ab89 100644
--- a/util/options.hh
+++ b/util/options.hh
@@ -76,7 +76,7 @@ struct option_parser_t
 
     add_main_options ();
   }
-  virtual ~option_parser_t (void)
+  ~option_parser_t (void)
   {
     g_option_context_free (context);
     g_ptr_array_foreach (to_free, (GFunc) g_free, nullptr);


More information about the HarfBuzz mailing list