[igt-dev] [PATCH i-g-t] tests/kms_psr_sink_crc: Save runtime by not waiting in crc function

Dhinakaran Pandiyan dhinakaran.pandiyan at intel.com
Thu Apr 5 23:36:46 UTC 2018




On Thu, 2018-04-05 at 13:58 +0300, Marta Lofstedt wrote:
> The get_sink_crc function usleep(300000) with motivation:
> "Now give a time for human eyes". However, the function has already
> exited early on igt_interactive_debug, so no human is waiting.
> Also, waiting for keypress is obsolete when not in
> igt_interactive_debug mode.
> 

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>

> Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 2b60acf3..98d29ba9 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -236,12 +236,6 @@ static void get_sink_crc(data_t *data, char *crc) {
>  	close(dir);
>  
>  	igt_debug("%s\n", crc);
> -	igt_debug_wait_for_keypress("crc");
> -
> -	/* The important value was already taken.
> -	 * Now give a time for human eyes
> -	 */
> -	usleep(300000);
>  
>  	/* Black screen is always invalid */
>  	igt_assert(strncmp(crc, CRC_BLACK, CRC_LEN) != 0);



More information about the igt-dev mailing list