[igt-dev] [PATCH i-g-t] kms_frontbuffer_tracking: Remove unnecessary modeset from get_sink_crc.

[Maarten Lankhorst]

Op 09-04-18 om 08:36 schreef Lofstedt, Marta:
> I confirm that this patch fix the issue at least on a HSW laptop.
>
> Reviewed-by: Marta Lofstedt <marta.lofstedt at intel.com>
>
>> -----Original Message-----
>> From: igt-dev [mailto:igt-dev-bounces at lists.freedesktop.org] On Behalf Of
>> Maarten Lankhorst
>> Sent: Friday, April 6, 2018 3:48 PM
>> To: igt-dev at lists.freedesktop.org
>> Subject: [igt-dev] [PATCH i-g-t] kms_frontbuffer_tracking: Remove
>> unnecessary modeset from get_sink_crc.
>>
>> get_sink_crc() wants the eDP panel enabled to collect a CRC, but this is
>> already required for opening the pipe CRC. This was broken in the conversion
>> to igt_display, because the call to setup_sink_crc was moved.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105503
>> Reported-by: Marta Löfstedt <marta.lofstedt at intel.com>
>> ---
>>  tests/kms_frontbuffer_tracking.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/tests/kms_frontbuffer_tracking.c
>> b/tests/kms_frontbuffer_tracking.c
>> index 454dbd1a349a..5a4a9bae4760 100644
>> --- a/tests/kms_frontbuffer_tracking.c
>> +++ b/tests/kms_frontbuffer_tracking.c
>> @@ -1448,14 +1448,6 @@ static void setup_sink_crc(void)
>>  		return;
>>  	}
>>
>> -	/* We need to make sure there's a mode set on the eDP
>> screen and it's
>> -	 * not on DPMS state, otherwise we fall into the "Unexpected
>> sink CRC
>> -	 * error" case. */
>> -	prim_mode_params.primary.fb =
>> &fbs[FORMAT_DEFAULT].prim_pri;
>> -	prim_mode_params.primary.x =
>> prim_mode_params.primary.y = 0;
>> -	fill_fb_region(&prim_mode_params.primary,
>> COLOR_PRIM_BG);
>> -	set_mode_for_params(&prim_mode_params);
>> -
>>  	sink_crc.fd = openat(drm.debugfs, "i915_sink_crc_eDP1",
>> O_RDONLY);
>>  	igt_assert_lte(0, sink_crc.fd);
>>
>> --
>> 2.16.3
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev

pushed, thanks for review. :)

~Maarten