[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep.

[Lofstedt, Marta]

https://patchwork.freedesktop.org/series/41269/
________________________________________
From: Zanoni, Paulo R
Sent: Monday, April 09, 2018 7:55 PM
To: Lofstedt, Marta; igt-dev at lists.freedesktop.org
Cc: Latvala, Petri
Subject: Re: [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep.

Em Sex, 2018-04-06 às 15:19 +0300, Marta Lofstedt escreveu:
> The kms_frontbuffer_tracking@*suspend subtests spend 20 seconds
> sleeping around igt_system_suspend_autoresume. I find no other
> igt test that require sleeping in relation to suspend-resume, so
> it should be removed.

If, and only if, you have data showing this won't cause problems on CI:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

>
> Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index a20e7118..d26078cc 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2830,15 +2830,11 @@ static void suspend_subtest(const struct
> test_mode *t)
>       struct modeset_params *params = pick_params(t);
>
>       prepare_subtest(t, NULL);
> -     sleep(5);
>       igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> SUSPEND_TEST_NONE);
> -     sleep(5);
>       do_assertions(ASSERT_DRRS_LOW);
>
>       unset_all_crtcs();
> -     sleep(5);
>       igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> SUSPEND_TEST_NONE);
> -     sleep(5);
>       do_assertions(ASSERT_FBC_DISABLED | ASSERT_PSR_DISABLED |
>                     DONT_ASSERT_CRC | ASSERT_DRRS_INACTIVE);
>