[igt-dev] [PATCH i-g-t v4 0/4] Refactoring of *_fill libraries

[Petri Latvala]

On Tue, Apr 10, 2018 at 10:12:28AM +0200, Katarzyna Dec wrote:
> This series is removing duplications in gpgpu_fill and media_fill
> libraries. As a first step I moved gpgpu and media helper functions
> to gpu_fill library. In second patch I adjusted code to our coding
> style. In the third not obvious duplications were removed (like
> adding in gen7 functions conditions for future gens). Last patch
> adds missing parameters that make GPU hang on gen9 and gen9+.
> 
> In first version of this series there was a comment about moving
> batch_alloc/copy etc. functions to intel_batchbuffer library.
> Because there is a lot of code to review already this change will
> be introduced in another series (rendercopy, media_fill, gpgpu_fill
> and media_spin code is affected by this).
> 
> It is possible that more changes around gen*_media.h and media_spin
> is needed, but this will be done as a next step.
> 
> v2: Removed not obvious duplications. Adjusted code to review comments.
> v3: Series needed reorganization because it introduced bug to ALP,
> which was hard to find. That is why patch 1 is now almost only moving functions to gpu_fill with removing duplications, such as the same functions. Also applied comments from review.
> v4: Added #defines and copyrights to new gpu_fill library. Changed functions
> order in gpu_fill library.


If you mean the header guards with #defines, they need to be there in
patch 1 already. Patch 1 alone doesn't build.


-- 
Petri Latvala