[igt-dev] [PATCH i-g-t v5 3/4] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill

Kalamarz, Lukasz lukasz.kalamarz at intel.com
Tue Apr 10 13:16:23 UTC 2018


On Tue, 2018-04-10 at 13:34 +0200, Katarzyna Dec wrote:
> There are missing parameters for Gen8 configuration of gpgpu_fill
> that are causing GPU hangs on newer hardware. We need to set the
> number of threads in TG in gen8_fill_interface_descriptor. This
> field was omitted (apparently without any side effects), but
> according to bspec from BDW this field cannot be set to 0. We also
> need to use pipeline selection mask to gen9_gpgpu_fillfunc, which
> is necessary from SKL.
> 
> v2: rebased on refactored library
> v3: Removed replacing gen7_emit_interface_descriptor_load with gen8
> version in gen9_gpgpgu_fillfunc, because during refactoring gen8
> function was removed.
> v4: rebase on series new version
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Looks good for me.
Reviewed-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>


More information about the igt-dev mailing list