[igt-dev] [PATCH i-g-t v4 2/2] add a kms_fb_stride test

Katarzyna Dec katarzyna.dec at intel.com
Wed Apr 11 13:27:29 UTC 2018


On Mon, Feb 26, 2018 at 03:47:03PM +0200, Martin Peres wrote:
> This test checks what strides are actually supported by each plane of
> each pipe. The tested strides are 4K, 8K, and 16K. The tested formats
> are DRM_FORMAT_RGB565 (16 bits) and DRM_FORMAT_XRGB8888 (32 bits).
> 
> To verify that the display controler is OK with the stride, the test
> uses the pipe crc and verifies that a test image blitted to a
> hdisplay x vdisplay framebuffer appears the same when blitted to a
> stride x vdisplay framebuffer (with stride varying from 4K to 16K).
> 
> v2:
>  - SKIP when a stride/format is not supported by the kernel
>  - perform a modeset at a low resolution on all pipes before running
>    a test in order to be fast and provide coverage even without
>    a display attached (requires a VGA or HDMI connector).
>  - generate a subtest per pipe, plane, format and stride
> 
> v3:
>  - if no VGA or HDMI connectors are found, fallback to any connected
>    connector
> 
> v4: comments from Ville Syrjälä
>  - make get_lowres_mode return a mode from the wanted connector
> 
Hello Martin,
I know that there will be a new version of this patches, so maybe
you could add IGT_TEST_DESCRIPTION to new test and check with 
checkpatch.pl for some style changes?
Patch with test looks good, but I wait with review for new version.

Kasia
> -- 
> 2.16.2
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list