[igt-dev] [PATCH i-g-t v3 2/3] lib/gen6_render: Reorder registers and fields definitions

Katarzyna Dec katarzyna.dec at intel.com
Thu Apr 12 06:13:41 UTC 2018


Hello Lukasz,
Huge work done here :) Generally all looks good. I found few lines
that probably should be reordered as well:
  Fields for PIPE CONTROL are higher than GEN6_PIPE_CONTROL.
  Fields:
#define PIPELINE_SELECT_3D  0
#define PIPELINE_SELECT_MEDIA   1              
are far from their register: GEN6_PIPELINE_SELECT.

Can you be more specific in commit msg what has changed?
Kasia
            



More information about the igt-dev mailing list