[igt-dev] [PATCH i-g-t 10/20] tests/psr: Remove delay between dpms toggle.

Dhinakaran Pandiyan dhinakaran.pandiyan at intel.com
Fri Apr 13 00:24:34 UTC 2018




On Thu, 2018-04-12 at 13:26 +0200, Katarzyna Dec wrote:
> On Tue, Apr 10, 2018 at 07:37:22PM -0700, Dhinakaran Pandiyan wrote:
> > No reason for the delay between dpms off and on.
> > 
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> > index d940ec89..17490726 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -428,7 +428,6 @@ static void dpms_off_on(data_t data)
> >  {
> >  	kmstest_set_connector_dpms(data.drm_fd, data.output->config.connector,
> >  				   DRM_MODE_DPMS_OFF);
> > -	sleep(1);
> Why there was as sleep at the first place here? Probably there was some reason.

Probably. It is not obvious though. The test works fine without it and
removing it cuts down the running time, which means we can run other
useful tests.

> Kasia
> >  	kmstest_set_connector_dpms(data.drm_fd, data.output->config.connector,
> >  				   DRM_MODE_DPMS_ON);
> >  }
> > -- 
> > 2.14.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev



More information about the igt-dev mailing list