[igt-dev] [PATCH i-g-t 14/20] tests/psr: Make testing with sink CRC non-default

[Katarzyna Dec]

On Tue, Apr 10, 2018 at 07:37:26PM -0700, Dhinakaran Pandiyan wrote:
> Testing with CRC has always been unreliable. CRC also appears to be
> suspectible to signal integrity of the link between source and sink.
> But, most importantly, I see that reading sink CRC causes PSR exits
> rendering CRC based testing for PSR exits pointless. So hide this under
> a non-default --sink-crc command line option.
> 
> This makes all tests other than basic and no-drrs require
> interactive-debug, but that's okay since using sink CRC is misleading.
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
 Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index bb92d672..c9197c9d 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -75,6 +75,7 @@ typedef struct {
>  	drmModeModeInfo *mode;
>  	igt_output_t *output;
>  	bool with_psr_disabled;
> +	bool with_sink_crc;
>  } data_t;
>  
>  static void create_cursor_fb(data_t *data)
> @@ -273,6 +274,10 @@ static void run_test(data_t *data)
>  	char crc[CRC_LEN];
>  	const char *expected = "";
>  
> +	if (!igt_interactive_debug)
> +		igt_require_f(data->with_sink_crc,
> +			      "Enable sink CRC with --sink-crc\n");
> +
>  	/* Confirm that screen became Green */
>  	get_sink_crc(data, ref_crc);
>  	assert_or_manual(is_green(ref_crc), "screen GREEN");
> @@ -438,6 +443,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  	case 'n':
>  		data->with_psr_disabled = true;
>  		break;
> +	case 'c':
> +		data->with_sink_crc = true;
> +		break;
>  	default:
>  		igt_assert(0);
>  	}
> @@ -448,9 +456,11 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  int main(int argc, char *argv[])
>  {
>  	const char *help_str =
> -	       "  --no-psr\tRun test without PSR to check the CRC test logic.";
> +	       "  --no-psr\tRun test without PSR to check the CRC test logic.\n"	\
> +	       "  --sink-crc\tRun tests using sink CRC";
>  	static struct option long_options[] = {
>  		{"no-psr", 0, 0, 'n'},
> +		{"sink-crc", 0, 0, 'c'},
>  		{ 0, 0, 0, 0 }
>  	};
>  	data_t data = {};
> -- 
> 2.14.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev