[igt-dev] [PATCH i-g-t 1/2] NOT_UPSTREAM: lib: explain that some gen9 functions do not extend to gen11

[Katarzyna Dec]

On Fri, Apr 13, 2018 at 09:25:38AM -0700, Ceraolo Spurio, Daniele wrote:
> 
> 
> On 4/13/2018 4:37 AM, Katarzyna Dec wrote:
> > From: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > 
> > Gen11 HW changes make the legacy function not applicable. Adding a
> > comment to track the fact that extending the gen9 version has been
> > considered and it is not doable.
> > 
> > v2: don't add a gen11 if statement (Lucas), update commit message
> > v3: Removed FIXME for gpgpu_fillfunc for Gen11.
> > 
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> 
> Double CC
> 
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> 
> I'm pretty sure I had an s-o-b on this patch. If you want to take ownership
> I don't really mind but as a general rule you shouldn't remove s-o-b tags
> from patches without a ping to the original authors first. If you update a
> patch you can usually just add your s-o-b tag below the existing one. btw,
> if you do take ownership you should change the author of the patch to
> yourself as well.
> 
> Daniele
Hello Daniele,
I didn't know that s-o-b should stay as it was previously. I will change it, of
course.
Kasia :)
> 
> > Signed-off-by: Katarzyna Dec <katarzyna.dec at intel.com>
> > ---
> >   lib/intel_batchbuffer.c | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> > index b78c3dca..008bc076 100644
> > --- a/lib/intel_batchbuffer.c
> > +++ b/lib/intel_batchbuffer.c
> > @@ -848,6 +848,16 @@ igt_media_spinfunc_t igt_get_media_spinfunc(int devid)
> >   {
> >   	igt_media_spinfunc_t spin = NULL;
> > +	/*
> > +	 * Gen11 FIXME: the gen9 version of the function does not work on gen11.
> > +	 * From the fulsim error log:
> > +	 *
> > +	 * "BSpec violation: MEDIA BLOCK WRITE messages require surfaces of
> > +	 * pitch alignment of 0x40, current surface pitch is 0x4"
> > +	 *
> > +	 * We need to add a new gen11-specific function.
> > +	 */
> > +
> >   	if (IS_GEN10(devid))
> >   		/* FIXME: Add proper gen10_media */
> >   		spin = gen9_media_spinfunc;
> >