[igt-dev] [PATCH i-g-t v4 2/4] lib/rendercopy_gen7: Cosmetic changes in code

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Fri Apr 20 23:54:09 UTC 2018



On 20/04/18 04:15, Lukasz Kalamarz wrote:
> This patch apply coding standard into rendercopy_gen7 library.
> No functional changes were made.
> 
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

<snip>


>   
>   static void
>   gen7_emit_null_depth_buffer(struct intel_batchbuffer *batch)
>   {
> -        OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER | (7 - 2));
> -        OUT_BATCH(GEN7_SURFACE_NULL << GEN7_3DSTATE_DEPTH_BUFFER_TYPE_SHIFT |
> -                  GEN7_DEPTHFORMAT_D32_FLOAT << GEN7_3DSTATE_DEPTH_BUFFER_FORMAT_SHIFT);
> -        OUT_BATCH(0); /* disable depth, stencil and hiz */
> -        OUT_BATCH(0);
> -        OUT_BATCH(0);
> -        OUT_BATCH(0);
> -        OUT_BATCH(0);
> +	OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER | (7 - 2));
> +	OUT_BATCH(GEN7_SURFACE_NULL << GEN7_3DSTATE_DEPTH_BUFFER_TYPE_SHIFT |
> +	GEN7_DEPTHFORMAT_D32_FLOAT << GEN7_3DSTATE_DEPTH_BUFFER_FORMAT_SHIFT);

Indentation still incorrect here.

Daniele

> +	OUT_BATCH(0); /* disable depth, stencil and hiz */
> +	OUT_BATCH(0);
> +	OUT_BATCH(0);
> +	OUT_BATCH(0);
> +	OUT_BATCH(0);
>   
> -        OUT_BATCH(GEN7_3DSTATE_CLEAR_PARAMS | (3 - 2));
> -        OUT_BATCH(0);
> -        OUT_BATCH(0);
> +	OUT_BATCH(GEN7_3DSTATE_CLEAR_PARAMS | (3 - 2));
> +	OUT_BATCH(0);
> +	OUT_BATCH(0);
>   }
>   
>   #define BATCH_STATE_SPLIT 2048
> @@ -571,9 +571,9 @@ void gen7_render_copyfunc(struct intel_batchbuffer *batch,
>   	gen7_emit_null_depth_buffer(batch);
>   	gen7_emit_cc(batch, blend_state, cc_viewport);
>   	gen7_emit_sampler(batch, ps_sampler_off);
> -        gen7_emit_sbe(batch);
> +	gen7_emit_sbe(batch);
>   	gen7_emit_ps(batch, ps_kernel_off);
> -        gen7_emit_vertex_elements(batch);
> +	gen7_emit_vertex_elements(batch);
>   	gen7_emit_vertex_buffer(batch, src_x, src_y,
>   				dst_x, dst_y, width,
>   				height, vertex_buffer);
> @@ -581,12 +581,12 @@ void gen7_render_copyfunc(struct intel_batchbuffer *batch,
>   	gen7_emit_drawing_rectangle(batch, dst);
>   
>   	OUT_BATCH(GEN7_3DPRIMITIVE | (7 - 2));
> -        OUT_BATCH(GEN7_3DPRIMITIVE_VERTEX_SEQUENTIAL | _3DPRIM_RECTLIST);
> -        OUT_BATCH(3);
> -        OUT_BATCH(0);
> -        OUT_BATCH(1);   /* single instance */
> -        OUT_BATCH(0);   /* start instance location */
> -        OUT_BATCH(0);   /* index buffer offset, ignored */
> +	OUT_BATCH(GEN7_3DPRIMITIVE_VERTEX_SEQUENTIAL | _3DPRIM_RECTLIST);
> +	OUT_BATCH(3);
> +	OUT_BATCH(0);
> +	OUT_BATCH(1);   /* single instance */
> +	OUT_BATCH(0);   /* start instance location */
> +	OUT_BATCH(0);   /* index buffer offset, ignored */
>   
>   	OUT_BATCH(MI_BATCH_BUFFER_END);
>   
> 


More information about the igt-dev mailing list