[igt-dev] [PATCH i-g-t v5 4/4] lib/intel_batchbuffer: Move batch functions from media/render/gpgpu libs

[Daniele Ceraolo Spurio]

On 23/04/18 07:20, Lukasz Kalamarz wrote:
> Batch functions were copy/pasted across several libs.
> With moving it into intel_batchbuffer lib test can now be
> easly maintained without worrying that we forgot to modify
> older version of lib.
> 
> v2: Added documentation into lib and rebased patch
> v3: Fixed typos and rebased patch
> v4: Fixed documentation issues
> v5: Rename, clean up of leftovers from previous version
> and documentation polishing
> 
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> ---
>   lib/gpgpu_fill.c        |  6 ++--
>   lib/gpu_fill.c          | 67 +++++++++++-----------------------------
>   lib/gpu_fill.h          | 15 ---------
>   lib/intel_batchbuffer.c | 80 +++++++++++++++++++++++++++++++++++++++++++-----
>   lib/intel_batchbuffer.h | 15 +++++++--
>   lib/media_fill_gen7.c   |  2 +-
>   lib/media_fill_gen8.c   |  2 +-
>   lib/media_fill_gen9.c   |  2 +-
>   lib/media_spin.c        | 62 ++++++++-----------------------------
>   lib/rendercopy_gen6.c   | 68 +++++++++++------------------------------
>   lib/rendercopy_gen7.c   | 64 +++++++++-----------------------------
>   lib/rendercopy_gen8.c   | 81 +++++++++++++++----------------------------------
>   lib/rendercopy_gen9.c   | 81 +++++++++++++++----------------------------------
>   13 files changed, 201 insertions(+), 344 deletions(-)
> 

<snip>

> +void *
> +intel_batchbuffer_subdata_alloc(struct intel_batchbuffer *batch, uint32_t size,
> +				uint32_t align)
> +{
> +	uint32_t offset = intel_batchbuffer_align(batch, align);
> +
> +	igt_assert(size < intel_batchbuffer_space(batch));

you can use "<=" here. With this fixed:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Daniele