[igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to fast feedback list

Petri Latvala petri.latvala at intel.com
Tue Apr 24 09:34:07 UTC 2018



On 04/24/2018 02:58 AM, Dhinakaran Pandiyan wrote:
>
>
> On Mon, 2018-04-23 at 16:06 -0700, Rodrigo Vivi wrote:
>> On Sat, Apr 14, 2018 at 06:13:40PM -0700, Dhinakaran Pandiyan wrote:
>>> On Fri, 2018-04-13 at 12:16 +0300, Petri Latvala wrote:
>>>> On Wed, Apr 11, 2018 at 07:14:36PM +0300, Pandiyan, Dhinakaran wrote:
>>>>> Yeah, that is expected. The kernel patches are not in yet.
>>>> The requirement for using --sink-crc is going away when kernel side
>>>> patches land? Or how is this planned?
>>>>
>>> Irrespective of whether or when the kernel patches land, --sink-crc will
>>> not be used for CI. --sink-crc is being retained for developers to
>>> manually use it for debug and possibly fix the code in future.
>>>
>>> Having said that, the kernel patches adding time stamp support should
>>> land soon, after which the tests will not skip.
>> Ok, I finally looked to all patches on this series and I support all of them.
>>
>> My only concern is actually with patch 14 that is around this discussion here...
>>
>> For me it seems that or you run with interactive debug on or with sink_crc
>> and CI is not running with any so it will all skip.
>>
>> Unless I missunderstood something on that patch...
>>
>> If CI still runs without requiring any extra option I'm in favor of the whole series
>> and I'm tending to merge it soon...
>>
> CI will not need any options. Timestamps are supported by default on all
> platforms except CHV/VLV. We don't have those platforms in CI and I am
> planning to nuke PSR support for them.
>

These machines are VLV:
fi-byt-j1900
fi-byt-n2820


-- 
Petri Latvala



More information about the igt-dev mailing list