[igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID

Souza, Jose jose.souza at intel.com
Sat Apr 28 00:00:28 UTC 2018


On Fri, 2018-04-27 at 16:36 -0700, Paulo Zanoni wrote:
> Em Sex, 2018-04-27 às 16:05 -0700, José Roberto de Souza escreveu:
> > This PCI ID was recently added to kernel in commit
> > '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
> > but not added here.
> 
> Please see "[PATCH igt 1/3] lib: sync with the newer i915_pciids.h
> from
> the Kernel (KBL + ICL)".

Oh I missed that patch.

So lets drop this one and go with yours.

> 
> We should just be copying i915_pciids.h from the Kernel to here, so
> both files stay in sync and differences are easier to spot.
> 
> This also means that the new ID should be added in a different spot.
> 
> Thanks,
> Paulo
> 
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Cc: James Ausmus <james.ausmus at intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> > ---
> >  lib/i915_pciids.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index 0b2ba46f..334d6321 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -354,7 +354,8 @@
> >  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> >  	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> >  	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> > -	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> > +	INTEL_VGA_DEVICE(0x591D, info), /* WKS GT2 */ \
> > +	INTEL_VGA_DEVICE(0x591C, info)  /* ULX GT2 */
> >  
> >  #define INTEL_KBL_GT3_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \


More information about the igt-dev mailing list