[igt-dev] [PATCH i-g-t] igt/gem_eio: Preserve batch between reset-stress iterations

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 8 14:19:27 UTC 2018


Quoting Tvrtko Ursulin (2018-08-08 13:57:56)
> 
> On 08/08/2018 13:47, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-08-08 13:38:53)
> >>
> >> On 08/08/2018 12:31, Chris Wilson wrote:
> >>>        igt_until_timeout(5) {
> >>> -             struct drm_i915_gem_execbuffer2 execbuf = { };
> >>> -             struct drm_i915_gem_exec_object2 obj = { };
> >>> -             uint32_t bbe = MI_BATCH_BUFFER_END;
> >>> +             uint32_t ctx = context_create_safe(fd);
> >>
> >> There is still this per loop...
> > 
> > I thought that was intentional :)
> > 
> > It felt like the spirit of the test to try and mix up the contexts as
> > much as possible; one constant, one fresh.
> 
> Yes definitely intentional (required), I was just puzzled why you are 
> concerned with removing one gem_create when we have more ioctls in the 
> loop anyway.

Low hanging fruit. Besides, I would cache the context objects if someone
would just turn a blind eye.
-Chris


More information about the igt-dev mailing list