[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11
Mika Kahola
mika.kahola at intel.com
Mon Aug 27 13:10:32 UTC 2018
On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
> Test DRM_FORMAT_RGB565 rotation when gen is 11 or higher.
>
Looks ok to me.
Reviewed-by: Mika Kahola <mika.kahola at intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
> tests/kms_plane_scaling.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 2f19a42..7c64ed1 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -156,10 +156,10 @@ static const igt_rotation_t rotations[] = {
> IGT_ROTATION_270,
> };
>
> -static bool can_rotate(unsigned format)
> +static bool can_rotate(data_t *d, unsigned format)
> {
> if (format == DRM_FORMAT_C8 ||
> - format == DRM_FORMAT_RGB565)
> + (intel_gen(d->devid) < 11 && format ==
> DRM_FORMAT_RGB565))
> return false;
>
> return true;
> @@ -180,7 +180,8 @@ static void test_scaler_with_rotation_pipe(data_t
> *d, enum pipe pipe,
> igt_rotation_t rot = rotations[i];
> for (int j = 0; j < plane->drm_plane-
> >count_formats; j++) {
> unsigned format = plane->drm_plane-
> >formats[j];
> - if (igt_fb_supported_format(format)
> && can_rotate(format))
> + if (igt_fb_supported_format(format)
> &&
> + can_rotate(d, format))
> check_scaling_pipe_plane_rot
> (d, plane, format,
>
> LOCAL_I915_FORMAT_MOD_Y_TILED,
>
> pipe, output, rot);
--
Mika Kahola - Intel OTC
More information about the igt-dev
mailing list