[igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware

[Dhinakaran Pandiyan]

On Thu, 2018-08-30 at 11:30 -0700, Rodrigo Vivi wrote:
> On Thu, Aug 30, 2018 at 12:19:56AM -0700, Dhinakaran Pandiyan wrote:
> > CI runs show PSR tests failing on the recently added BDW (fi-bdw-
> > samus), it
> > makes sense to enable these tests when we know they are expected to
> > pass.
> > 
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> > ---
> >  tests/kms_psr.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index 218b3960..52b71826 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -411,6 +411,7 @@ int main(int argc, char *argv[])
> >  		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
> >  		kmstest_set_vt_graphics_mode();
> >  		data.devid = intel_get_drm_devid(data.drm_fd);
> > +		igt_require(AT_LEAST_GEN(data.devid, 9));
> 
> oh! I liked this macro... why don't we have the same on kernel side?
> :)
> 
> but as we talked in pvt I don't like the approach. I prefer that
> we keep honest and transparent of the issues that we have on previous
> gens.
> 
> Also we have the visibility if any change we make targeting gen9
> is not possibly fixing or causing even more troubles on older gens.
> 
Fair enough, dropping this patch.

Thanks
DK

> Thanks,
> Rodrigo.
> 
> >  
> >  		igt_set_module_param_int("enable_psr",
> > data.with_psr_disabled ?
> >  					 0 : 1);
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev