[igt-dev] [PATCH i-g-t v3] lib/drmtest: Move open device to separate function

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 31 11:59:51 UTC 2018


Quoting Petri Latvala (2018-08-31 12:51:08)
> On Fri, Aug 31, 2018 at 01:00:49PM +0200, Katarzyna Dec wrote:
> > While working on IGT code and during reviewes I've noticed that
> > it could be nice to have function that is opening particular device.
> > Let's move out conditions for opening device and rename __open_device
> > to __search_and_open() function.
> > 
> > v2: Refactored open_device even more by getting device name once and
> > returning fd for it. (Chris)
> > v3: Added name_size to __get_drm_device_name.
> > 
> > Signed-off-by: Katarzyna Dec <katarzyna.dec at intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> 
> 
> 
> This breaks opening virtio_gpu.

Of course they needed to be different and have distinct names for their
module and driver.
-Chris


More information about the igt-dev mailing list