[igt-dev] [PATCH i-g-t] lib: Stop caching __drm_device_id

Katarzyna Dec katarzyna.dec at intel.com
Fri Aug 31 13:10:55 UTC 2018


On Fri, Aug 31, 2018 at 01:18:53PM +0100, Chris Wilson wrote:
> In a multi-device system there is no guarantee that the fd being probed
> in intel_get_drm_devid() is the same as was opened earlier. Any cache
> may outlive the fd, so is frought with lifetime issues. The primary
> reason for caching the devid was to avoid extra ioctls in the
> dmesg/strace, but hopefully all users now grab the id in their fixture
> and not inside every function.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>

I will probably have conflict with this patch, but it is ok.
Kasia :)



More information about the igt-dev mailing list