[igt-dev] [PATCH i-g-t v4 1/3] lib/ioctl_wrapper: Add i915_get_param helper

[Chris Wilson]

Quoting Lukasz Kalamarz (2018-12-04 16:25:24)
> getparam is used in few places across IGT, but no helper function
> is used to reduce code duplication.
> 
> v2: Added doc part and changed return value in case of error
> v3: Renamed function to i915_get_param, created internal error
> checking function and helper function to check if given feature
> is enabled.
> 
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> 
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Petri Latvala <Petri.latvala at intel.com>
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Ankit K Nautiyal <ankit.k.nautiyal at intel.com>
> ---
>  lib/ioctl_wrappers.c | 50 ++++++++++++++++++++++++++++++++++++++++++++
>  lib/ioctl_wrappers.h |  2 ++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 9f255508..b48dad5b 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c

Out of the freedom of lib/i915/*, you chose lib/ioctl_wrappers.c for this
i915 specific interface?
-Chris